fix: remove token informations from local storage after succesful logout #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
During the logout process for the icm and punchout identity provider only the apiToken cookie will be removed. The related access token information within the localStorage, which is handled by the OAuthService, will not be deleted. This can lead to unwanted behavior, that the OAuthService triggers an action to refresh the revoked access_token.
What Is the New Behavior?
The pwa will remove for the icm and punchout identity provider all access_token informations, when the logout of the user is successful.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#88809