Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: save orderReferenceId as native basket attribute #1499

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Sep 5, 2023

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The customer order id (order reference id) is saved as custom attribute 'orderReferenceId' at the basket.

Issue Number: Closes #

What Is the New Behavior?

The customer order id is saved as native attribute 'externalOrderReference' at the basket.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#89233

@SGrueber SGrueber self-assigned this Sep 5, 2023
@SGrueber SGrueber added the refactoring Refactoring of current code label Sep 5, 2023
@SGrueber SGrueber added this to the 4.2 milestone Sep 5, 2023
@SGrueber SGrueber force-pushed the refactor/orderReferenceId branch 2 times, most recently from 007b36f to 091bccc Compare September 6, 2023 10:31
@shauke shauke merged commit 7c160ce into develop Sep 8, 2023
21 checks passed
@shauke shauke deleted the refactor/orderReferenceId branch September 8, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants