feat: newsletter subscription #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Oct 20, 2023
...registration/formly/registration-newsletter-field/registration-newsletter-field.component.ts
Outdated
Show resolved
Hide resolved
...gistration/formly/registration-newsletter-field/registration-newsletter-field.component.html
Outdated
Show resolved
Hide resolved
...gistration/formly/registration-newsletter-field/registration-newsletter-field.component.html
Outdated
Show resolved
Hide resolved
SGrueber
requested changes
Jan 18, 2024
LucasHengelhaupt
force-pushed
the
feat/newsletter-subscription
branch
from
275ab0a
to
13d2b63
Compare
LucasHengelhaupt
force-pushed
the
feat/newsletter-subscription
branch
from
13d2b63
to
3df4409
Compare
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
apodkopaeva
reviewed
Feb 19, 2024
apodkopaeva
reviewed
Feb 19, 2024
|
FR localization will follow |
mglatter
previously approved these changes
Feb 21, 2024
schadii
previously approved these changes
Feb 21, 2024
LucasHengelhaupt
dismissed stale reviews from schadii, iwiederhold, and mglatter
via
229a0c3
mglatter
reviewed
Feb 22, 2024
src/assets/i18n/fr_FR.json
Outdated
| "subscriptions.not_subscribed": "non abonné", | ||
| "subscriptions.recipient.already_subscribed.error": "Vous vous êtes déjà inscrit au bulletin d’information.", | ||
| "subscriptions.subscribed": "abonné", | ||
| "subscriptions.subscription_not_found.error": "Aucun abonnement à la newsletter n’a été trouvé.", |
There was a problem hiding this comment.
We still need to check this one, has been overlooked so far...
mglatter
reviewed
Feb 22, 2024
src/assets/i18n/en_US.json
Outdated
| "subscriptions.not_subscribed": "not subscribed", | ||
| "subscriptions.recipient.already_subscribed.error": "You have already subscribed to the newsletter.", | ||
| "subscriptions.subscribed": "subscribed", | ||
| "subscriptions.subscription_not_found.error": "No newsletter subscription found.", |
mglatter
previously approved these changes
Feb 23, 2024
|
Azure Demo Servers are available: |
SGrueber
approved these changes
Feb 26, 2024
mglatter
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
Precondition:
In the channel preferences of the ICM back office an e-mail marketing provider is configured.
What Is the New Behavior?
The registered user can subscribe to the newsletter service at the registration page and can change this subscription in the account profile settings.
This functionality is not available for unregistered storefront visitors.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
Review and testing information:
In the b2c channel the newsletter subscription feature is currently switched off, in the b2b channel the feature is switched on
AB#90374