feat: support half-yearly and yearly budget periods #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marschmidt89
previously approved these changes
Nov 30, 2023
SGrueber
changed the title
|
@clindeIntershop If I try to change a user budget to 'half-yearly' I get a 400 http error:
Is there a certain ICM version needed for this feature? Please comment it at this pull request. |
|
@SGrueber yes you need a new (actually not released) ICM version that can handle this states. Where should i write this dependency so that the feature is not merged before the new ICM is released? |
SGrueber
force-pushed
the
bugfix/add-costcenter-budget-periodes
branch
from
9323643 to
433cfb8
Compare
SGrueber
force-pushed
the
bugfix/add-costcenter-budget-periodes
branch
2 times, most recently
from
6552465 to
7cb37f1
Compare
* new budget periods 'half-yearly and 'yearly'
SGrueber
force-pushed
the
bugfix/add-costcenter-budget-periodes
branch
from
7cb37f1 to
d347260
Compare
SGrueber
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
It is not possible to select the budget periods 'half-yearly' or 'yearly' for cost center or user budgets.
Issue Number: Closes #
What Is the New Behavior?
The budget periods 'half-yearly' and 'yearly' are supported.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
requires ICM version 11.8/7.10.6/7.10.38.29-LTS or higher
AB91481
AB#91577