fix: remove sortkey 'default' from product list REST call #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inconsistent results The "sortKey" and "sorting" parameter is set to "default" when the "Default Sorting" option is selected via dropdown. This leads to incorrect sorting of the products, as this "default" parameter is not an existing sorting key.
shauke
force-pushed
the
bugfix/default_sortkey
branch
from
74387f2
to
6949ece
Compare
shauke
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The REST call for fetching products for a product family page contains always a parameter 'sortKey' even if no special sort option is selected (in this case sortKey = 'default')
Issue Number: Closes #
What Is the New Behavior?
The parameter 'sortKey' is not appended at the product REST request if the default sorting is selected.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#91958