fix: infinite loop can occur in the mapping of the content page tree #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
requested changes
Jan 16, 2024
src/app/core/models/content-page-tree-view/content-page-tree-view.model.ts
Outdated
Show resolved
Hide resolved
dhhyi
previously approved these changes
Jan 17, 2024
shauke
changed the title
shauke
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
In production, we encountered a particular case, occurring only in server-side rendering, which contained the formation of a content-page-tree looping back on itself.
It was not possible to identify the code that led to this case.
However, the mapper was strengthened to avoid iterating indefinitely in the previous case.
Additionally observed circular references in the content page tree path calculation where removed
Does this PR Introduce a Breaking Change?
[x] No
Other Information