Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make order list presentational #1565

Merged
merged 3 commits into from
Jan 11, 2024
Merged

refactor: make order list presentational #1565

merged 3 commits into from
Jan 11, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 4, 2024 •
edited by SGrueber
Loading

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

ish-order-list has too many tasks:

  • can be fed with a list of orders
  • can alternatively fetch orders themself
  • switches the no-orders message themself depending if supplied with order list
  • truncates the list if supplied with input parameter
  • implicitly disables linking to details page if orders supplied directly

Performance issue:

  • for the account order widget 30 orders are fetched, but only 5 displayed
  • all additional properties for orders are fetched even if not used

What Is the New Behavior?

ish-order-list is strictly presentational, components using it supply the data.

Does this PR Introduce a Breaking Change?

[x] Yes
[ ] No

BREAKING CHANGE: orders API call now uses additionally the new limit parameter (requires ICM 11.6), the deprecated page[limit]will be removed soon

Other Information

AB#92479

@dhhyi dhhyi added refactoring Refactoring of current code performance Performance improvements labels Jan 4, 2024
@dhhyi dhhyi self-assigned this Jan 4, 2024
@dhhyi dhhyi force-pushed the refactor/order-list-presentational branch from b82c320 to 6aa2365 Compare January 4, 2024 16:09
dhhyi added a commit that referenced this pull request Jan 4, 2024
@dhhyi
refactor: make order-list presentational (#1565)
e9114dd
dhhyi added a commit that referenced this pull request Jan 4, 2024
@dhhyi
perf: optimize getting order lists (#1565)
6aa2365 
BREAKING CHANGE: orders API call now uses the new `limit` parameter instead of the deprecated `page[limit]` (requires ICM 11.6)
@dhhyi dhhyi force-pushed the refactor/order-list-presentational branch from 6aa2365 to 4732935 Compare January 4, 2024 16:36
dhhyi added a commit that referenced this pull request Jan 4, 2024
@dhhyi
perf: optimize getting order lists (#1565)
4732935 
BREAKING CHANGE: orders API call now uses the new `limit` parameter instead of the deprecated `page[limit]` (requires ICM 11.6)
@dhhyi dhhyi force-pushed the refactor/order-list-presentational branch from 4732935 to 0da5a65 Compare January 4, 2024 16:56
dhhyi added a commit that referenced this pull request Jan 4, 2024
@dhhyi
refactor: make order-list presentational (#1565)
661767d
dhhyi added a commit that referenced this pull request Jan 4, 2024
@dhhyi
perf: optimize getting order lists (#1565)
0da5a65 
BREAKING CHANGE: orders API call now uses the new `limit` parameter instead of the deprecated `page[limit]` (requires ICM 11.6)
dhhyi added a commit that referenced this pull request Jan 5, 2024
@dhhyi
refactor: make order-list presentational (#1565)
ddc85d0
dhhyi added a commit that referenced this pull request Jan 5, 2024
@dhhyi
perf: optimize getting order lists (#1565)
a50fc53 
BREAKING CHANGE: orders API call now uses the new `limit` parameter instead of the deprecated `page[limit]` (requires ICM 11.6)
@dhhyi dhhyi force-pushed the refactor/order-list-presentational branch from 0da5a65 to a50fc53 Compare January 5, 2024 08:28
@dhhyi dhhyi requested a review from SGrueber January 5, 2024 08:28
@dhhyi dhhyi marked this pull request as ready for review January 5, 2024 08:28
@dhhyi dhhyi removed their assignment Jan 5, 2024
SGrueber added a commit that referenced this pull request Jan 9, 2024
@SGrueber
fixup! refactor: make order-list presentational (#1565)
c11c61c
SGrueber added a commit that referenced this pull request Jan 9, 2024
@SGrueber
fixup! perf: optimize getting order lists (#1565)
1305a98
SGrueber added a commit that referenced this pull request Jan 9, 2024
@SGrueber
fix: display error message on order history page #1565
c3cf65e
SGrueber pushed a commit that referenced this pull request Jan 10, 2024
@dhhyi @SGrueber
perf: optimize getting order lists (#1565)
b059457 
BREAKING CHANGE: orders API call now uses the new `limit` parameter instead of the deprecated `page[limit]` (requires ICM 11.6)
SGrueber added a commit that referenced this pull request Jan 10, 2024
@SGrueber
fix: display error message on order history page #1565
eea98a8
@SGrueber SGrueber force-pushed the refactor/order-list-presentational branch from c3cf65e to eea98a8 Compare January 10, 2024 08:24
dhhyi and others added 2 commits January 11, 2024 10:40
@dhhyi @SGrueber
perf: optimize getting order lists (#1565)
18a8fb7 
BREAKING CHANGE: orders API call now uses additionally the `limit` parameter (requires ICM 11.6), the deprecated `page[limit]` parameter will be removed soon
@SGrueber
fix: display error message on order history page #1565
5bbcbc2
@SGrueber SGrueber force-pushed the refactor/order-list-presentational branch from eea98a8 to 5bbcbc2 Compare January 11, 2024 09:45
@SGrueber SGrueber added this to the 5.1 milestone Jan 11, 2024
@SGrueber SGrueber self-assigned this Jan 11, 2024
@SGrueber SGrueber merged commit a93e17d into develop Jan 11, 2024
22 checks passed
@SGrueber SGrueber deleted the refactor/order-list-presentational branch January 11, 2024 11:14
SGrueber pushed a commit that referenced this pull request Jan 11, 2024
@dhhyi @SGrueber
refactor: make order-list presentational (#1565)
7dcd24f
SGrueber pushed a commit that referenced this pull request Jan 11, 2024
@dhhyi @SGrueber
perf: optimize getting order lists (#1565)
9211841 
BREAKING CHANGE: orders API call now uses additionally the `limit` parameter (requires ICM 11.6), the deprecated `page[limit]` parameter will be removed soon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrueber SGrueber SGrueber approved these changes

Assignees

@SGrueber SGrueber

Labels
performance Performance improvements refactoring Refactoring of current code
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @SGrueber