fix: html injection on search page if there is no result #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
added a commit
that referenced
this pull request
Jan 15, 2024
* introduce `htmlEncode` pipe to encode potentially malicious HTML code * add documentation note
shauke
added a commit
that referenced
this pull request
Jan 15, 2024
…as string (#1575) * add documentation note
shauke
force-pushed
the
bugfix/search_html_injection
branch
from
2d7bd69
to
dcccfbb
Compare
shauke
approved these changes
Jan 16, 2024
shauke
added a commit
that referenced
this pull request
Jan 16, 2024
…as string (#1575) * add documentation note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Feature
What Is the Current Behavior?
If the user enters a search term in the search bar, that contains HTML it is rendered on the search-no-result page. This represents a security risk.
What Is the New Behavior?
The search term is not rendered as HTML but as an encoded string on the search-no-result page.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#92726
AB#92341