Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: lazily fetch products for CMS carousels #1581

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 26, 2024

PR Type

[x] Other: Performance Improvement

What Is the Current Behavior?

All products given to ish-products-list are fetched even if not even displayed.

What Is the New Behavior?

Lazy fetching when using slides.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#93254

@dhhyi dhhyi self-assigned this Jan 26, 2024
@dhhyi dhhyi marked this pull request as ready for review January 29, 2024 08:41
@dhhyi dhhyi removed their assignment Jan 29, 2024
@shauke shauke added this to the 5.1 milestone Jan 29, 2024
@shauke shauke merged commit cbe9072 into develop Jan 29, 2024
24 checks passed
@shauke shauke deleted the perf/lazy-products-list-component branch January 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants