fix: prevent rendering errors for text on enhanced image teaser caused by Angular hydration #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by Angular hydration * Angular hydration needs a valid HTML structure that was not given with the surrounding <p> tag for the text/description on the image * use <div> instead of <p> element for freestyle HTML on enhanced image teaser to prevent rendering errors * see https://angular.io/guide/hydration#valid-html-structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
Problem
<p>tag for the text/description on the image since the standard freestyle HTML is included in<p>tags and<p>in<p>resulted in hydration errors<div>instead of<p>element for freestyle HTML on enhanced image teaser to prevent rendering errorsDoes this PR Introduce a Breaking Change?
[x] No
Other Information
AB#93448