Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lazy Loading of Sub categories #1586

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented Feb 21, 2024

PR Type

[x] Feature
[x] Other: performance improvement

What Is the Current Behavior?

Currently, the configured level of main navigation categories (mainNavigationMaxSubCategoriesDepth) is loaded already on the server side. Therefore the SSR rendered HTML page contains a lot of unneeded category data (main navigation HTML, transfer state, transfered REST call content).

What Is the New Behavior?

The goal is to reduce the load time/size of HTML pages in the project. Only the top-level categories are now being loaded and rendered on SSR while the sub-level categories are loaded and rendered on the client side.

  • "lazy loading" of sub categories for the main navigation only on client side
  • reduce rendered main navigation code in SSR rendered HTML
  • reduce categories content of the transfer state
  • decrease needed transfer size per SSR page

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#94097

@DilaraGueler DilaraGueler self-assigned this Feb 21, 2024
@DilaraGueler DilaraGueler added the feature New feature or request label Feb 21, 2024
@DilaraGueler DilaraGueler marked this pull request as ready for review February 21, 2024 10:52
…render the configured level of sub categories

* "lazy loading" of sub categories for the main navighation only on client side
* reduce rendered main navigation code in SSR rendered HTML
* reduce categories content of the transfer state
* decrease needed tranfer size per SSR page
@shauke shauke force-pushed the feature/sub-categories-lazy-loading branch from 5be227c to 750c9cf Compare March 4, 2024 16:00
@shauke shauke added performance Performance improvements and removed feature New feature or request labels Mar 4, 2024
@shauke shauke added this to the 5.1 milestone Mar 4, 2024
@shauke shauke merged commit b589113 into develop Mar 4, 2024
21 of 22 checks passed
@shauke shauke deleted the feature/sub-categories-lazy-loading branch March 4, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants