-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lazy loading switch option for the Enhanced Image Teaser component #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 1, 2024 09:00
8121dbe
to
1e56024
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
3 times, most recently
from
March 4, 2024 12:59
962fd49
to
14a366d
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 4, 2024 15:20
14a366d
to
1972954
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
2 times, most recently
from
March 5, 2024 10:30
4297cda
to
f6a7da8
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 5, 2024 12:00
f6a7da8
to
56504a0
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 5, 2024 13:45
56504a0
to
ec85c59
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 6, 2024 15:58
ec85c59
to
f70f973
Compare
Azure Demo Servers are available: |
suschneider
force-pushed
the
chore/improve-CWV-homepage
branch
2 times, most recently
from
March 18, 2024 09:51
596b656
to
9049103
Compare
* cleanup, documentation, simplification
shauke
force-pushed
the
chore/improve-CWV-homepage
branch
from
March 25, 2024 16:39
9049103
to
9e99504
Compare
shauke
changed the title
chore: CWV improvements for homepage
feat: lazy loading switch option for the Enhanced Image Teaser component
Mar 25, 2024
shauke
previously approved these changes
Mar 26, 2024
mglatter
previously approved these changes
Mar 27, 2024
mglatter
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
CMS image components (Image Teaser and Enhanced Image Teaser) are loaded lazily on a page. This leads to a decreasing of CWV when this image component is located on a prominent place on a page, e.g. the home page.
What Is the New Behavior?
The rendering of the enhanced image teaser is changed and is no longer loading the image with
loading="lazy"
by default.If
loading="lazy"
is explicitly intended for certain Enhanced Image Teaser component the classloading-lazy
can be added to configuration parameter 'CS Class' .Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#94501