Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lazy loading switch option for the Enhanced Image Teaser component #1591

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

suschneider
Copy link
Collaborator

@suschneider suschneider commented Feb 29, 2024

PR Type

[x] Feature

What Is the Current Behavior?

CMS image components (Image Teaser and Enhanced Image Teaser) are loaded lazily on a page. This leads to a decreasing of CWV when this image component is located on a prominent place on a page, e.g. the home page.

What Is the New Behavior?

The rendering of the enhanced image teaser is changed and is no longer loading the image with loading="lazy" by default.
If loading="lazy" is explicitly intended for certain Enhanced Image Teaser component the class loading-lazy can be added to configuration parameter 'CS Class' .

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#94501

@suschneider suschneider self-assigned this Feb 29, 2024
Copy link

github-actions bot commented Mar 1, 2024

Azure Demo Servers are available:

@suschneider suschneider force-pushed the chore/improve-CWV-homepage branch 3 times, most recently from 962fd49 to 14a366d Compare March 4, 2024 12:59
Copy link

github-actions bot commented Mar 4, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 4, 2024

Azure Demo Servers are available:

@suschneider suschneider force-pushed the chore/improve-CWV-homepage branch 2 times, most recently from 4297cda to f6a7da8 Compare March 5, 2024 10:30
Copy link

github-actions bot commented Mar 5, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 5, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 5, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 6, 2024

Azure Demo Servers are available:

@shauke shauke added this to the 5.1 milestone Mar 14, 2024
@suschneider suschneider force-pushed the chore/improve-CWV-homepage branch 2 times, most recently from 596b656 to 9049103 Compare March 18, 2024 09:51
@shauke shauke force-pushed the chore/improve-CWV-homepage branch from 9049103 to 9e99504 Compare March 25, 2024 16:39
@shauke shauke changed the title chore: CWV improvements for homepage feat: lazy loading switch option for the Enhanced Image Teaser component Mar 25, 2024
@shauke shauke marked this pull request as ready for review March 25, 2024 16:40
shauke
shauke previously approved these changes Mar 26, 2024
@shauke shauke added the enhancement Enhancement to an existing feature label Mar 26, 2024
mglatter
mglatter previously approved these changes Mar 27, 2024
@shauke shauke merged commit 650dcf3 into develop Mar 27, 2024
16 checks passed
@shauke shauke deleted the chore/improve-CWV-homepage branch March 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants