feat: handle complex values of variation attributes #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
feat/complex-variation-attribute-values
branch
from
220cdcc
to
c1b9b8b
Compare
dhhyi
force-pushed
the
fix/variation-display-when-no-var-attrs
branch
from
f11ea73
to
2ed4842
Compare
dhhyi
force-pushed
the
feat/complex-variation-attribute-values
branch
from
c1b9b8b
to
e43245f
Compare
dhhyi
changed the base branch from
fix/variation-display-when-no-var-attrs
to
develop
dhhyi
force-pushed
the
feat/complex-variation-attribute-values
branch
from
e43245f
to
12405fd
Compare
SGrueber
force-pushed
the
feat/complex-variation-attribute-values
branch
from
12405fd
to
89c1fd3
Compare
SGrueber
approved these changes
Mar 22, 2024
shauke
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Variation attribute values can be supplied in different data types by the ICM, like string, number or even a complex data type 'quantity' consisting of a number value and a unit, which is often used in customer projects.
The inSPIRED store currently only supports string attributes, other attribute data types don't work properly.
What Is the New Behavior?
Number and complex values of variation attributes are supported.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#94653