fix: use a prefix (icm_) for internal token oauth storage #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
approved these changes
Mar 14, 2024
|
@tbouliere-datasolution Thank you for this pull request. I renamed the prefix of the token keys to 'icm' and fixed some linting and test issues. Please let me know whether you agree to these changes, so that I can merge your PR. |
|
Fine by me 👍 |
shauke
pushed a commit
that referenced
this pull request
Mar 15, 2024
--------- Co-authored-by: Silke <s.grueber@intershop.de>
shauke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Currently, the pwa uses a dedicated instance of
OauthServicefortoken.service.ts.But as it doesn't redefine the associated
OAuthStorage, all persistent data is shared between SSO implementations (like the bearer token).What Is the New Behavior?
This fix adds the
icm_prefix in front of all keys read and written bytoken.service.ts.Does this PR Introduce a Breaking Change?
[x ] No
Other Information