fix: render CMS content based on component templates correctly #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
bugfix/component_templates
branch
from
b1cac1b
to
aada715
Compare
SGrueber
force-pushed
the
bugfix/component_templates
branch
from
aada715
to
200a747
Compare
shauke
added a commit
that referenced
this pull request
Mar 22, 2024
* necessary to save pagelet information to the ngrx store with context information, plain id based normalization does not work for component templates
shauke
force-pushed
the
bugfix/component_templates
branch
from
200a747
to
a7d4b9a
Compare
* necessary to save pagelet information to the ngrx store with context information, plain id based normalization does not work for component templates
shauke
force-pushed
the
bugfix/component_templates
branch
from
a7d4b9a
to
7531388
Compare
shauke
changed the title
shauke
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
If the CMS content uses nested component templates the rendering result might not look as expected and result in the display of duplicated content.
What Is the New Behavior?
Using component templates won't result in duplicated content because all pagelets get a unique ids in the ngrx state management even if component templates are used.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#95047