Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Order Template from Order #1610

Merged
merged 15 commits into from
Apr 8, 2024

Conversation

LucasHengelhaupt
Copy link
Contributor

@LucasHengelhaupt LucasHengelhaupt commented Mar 19, 2024

PR Type

[x] Feature

What Is the Current Behavior?

The PWA does not yet handle creating an order-template from an existing order.

Issue Number: Closes #

What Is the New Behavior?

The user can create an order-template from the order details page with all the items from that order.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#95134

@LucasHengelhaupt LucasHengelhaupt added the feature New feature or request label Mar 26, 2024
@SGrueber SGrueber added this to the 5.2 milestone Mar 27, 2024
@SGrueber SGrueber force-pushed the feat/order-template-from-order branch from 6e59d16 to 4b42495 Compare March 28, 2024 12:43
Copy link

github-actions bot commented Apr 2, 2024

Azure Demo Servers are available:

Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the appearance of the button again.

Copy link

github-actions bot commented Apr 3, 2024

Azure Demo Servers are available:

iwiederhold
iwiederhold previously approved these changes Apr 3, 2024
@SGrueber SGrueber requested review from M-Behr and a team April 3, 2024 11:10
schadii
schadii previously approved these changes Apr 3, 2024
"account.order_template.new_from_order.button.create.label": "Create",
"account.order_template.new_from_order.heading": "Create Order Template from Order",
Copy link
Contributor

@mglatter mglatter Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use sentence case.

Copy link
Collaborator

@SGrueber SGrueber Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want keep the application consistent. That's why we should not use the sentence case at one place. Please, let's keep it here as it is and change the notation over the whole application at once.
The modal titles are uppercase, anyway so changing the notation would not take effect
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arvid is already working on the task to unify to sentence case but I doubt that his file already contains these new keys. So I thought we'd better consider this for new keys already. Else it might be overlooked. If it doesn't take effect elsewhere, it's even more an argument for adjusting it while we spot it, isn't it? But you can also check with Arvid. I don't want to provoke any merge conflicts either.

M-Behr
M-Behr previously approved these changes Apr 4, 2024
SGrueber
SGrueber previously approved these changes Apr 4, 2024
@SGrueber SGrueber dismissed stale reviews from M-Behr, schadii, iwiederhold, and themself via 2ff5308 April 5, 2024 06:43
@SGrueber SGrueber force-pushed the feat/order-template-from-order branch from d0d12bb to fd65875 Compare April 5, 2024 15:26
@SGrueber SGrueber merged commit 553e05a into develop Apr 8, 2024
21 checks passed
@SGrueber SGrueber deleted the feat/order-template-from-order branch April 8, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants