-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Order Template from Order #1610
Conversation
...rder-templates/shared/order-create-order-template/order-create-order-template.component.html
Outdated
Show resolved
Hide resolved
.../order-templates/shared/order-create-order-template/order-create-order-template.component.ts
Outdated
Show resolved
Hide resolved
...r-templates/shared/order-create-order-template/order-create-order-template.component.spec.ts
Show resolved
Hide resolved
src/app/extensions/order-templates/store/order-template/order-template.effects.ts
Show resolved
Hide resolved
6e59d16
to
4b42495
Compare
Azure Demo Servers are available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the appearance of the button again.
Azure Demo Servers are available: |
src/assets/i18n/en_US.json
Outdated
"account.order_template.new_from_order.button.create.label": "Create", | ||
"account.order_template.new_from_order.heading": "Create Order Template from Order", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use sentence case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arvid is already working on the task to unify to sentence case but I doubt that his file already contains these new keys. So I thought we'd better consider this for new keys already. Else it might be overlooked. If it doesn't take effect elsewhere, it's even more an argument for adjusting it while we spot it, isn't it? But you can also check with Arvid. I don't want to provoke any merge conflicts either.
2ff5308
d0d12bb
to
fd65875
Compare
PR Type
[x] Feature
What Is the Current Behavior?
The PWA does not yet handle creating an order-template from an existing order.
Issue Number: Closes #
What Is the New Behavior?
The user can create an order-template from the order details page with all the items from that order.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#95134