fix: confirming cookie preferences removes punchout related cookies #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* punchout cookies have to be added to the list of required cookies * if punchout cookies are removed with the cookies consent the punchout functionality will no longer work as expected * added to documentation as well
SGrueber
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
If a new punchout session is opened and if the cookie banner is presented and if the user accepts any of the cookie consent options all cookies that are not listed as
allowedCookiesare deleted. Unfortunately this also happens to the just set punchout cookies and therefore the punchout functionality will no longer work as expected.What Is the New Behavior?
The punchout cookies were added to the list of required cookies (
allowedCookies) and with that they are no longer removed when setting the cookie consent. Meaning the punchout functionality works as expected.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#95355