fix: save address doctor configuration in the ngrx store #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
bugfix/save_address_doctor_configuration
branch
3 times, most recently
from
52b76b2 to
20b5b8e
Compare
…works with SSR * save Address Doctor configuration in the ngrx store/address-doctor-store.module.ts * so the configuration can be provided in the docker_compose or in a deployment yaml file and be transfered from SSR to client side in the browser
shauke
force-pushed
the
bugfix/save_address_doctor_configuration
branch
from
20b5b8e to
38a4896
Compare
shauke
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The Address Doctor has to be configured in the
environment.tsfile. The feature does not take effect when providing the necessary configurations in a YAML file for a Flux deployment or in adocker_composefile.What Is the New Behavior?
The address doctor can be configured in a YAML file for a Flux deployment or in a
docker_composefile as well.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#95679