feat: exclusive ICM url for SSR process #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
chore/ssr-exclusive-icm-url
branch
from
b873105 to
10234f5
Compare
dhhyi
force-pushed
the
chore/ssr-exclusive-icm-url
branch
from
10234f5 to
cca32fe
Compare
shauke
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
SSR process uses the same external URL for the ICM as the browser application.
What Is the New Behavior?
Introduced
ICM_BASE_URL_SSRwhich can be optionally set to use a different URL for the ICM in the SSR process.This is useful for testing and could be used in deployments, were the ICM runs in the same Kubernetes cluster as the PWA deployment.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#95720