refactor: enforce consistent pipe prefix #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/enforce-pipe-prefix
branch
from
56b1a6a
to
f7b1a02
Compare
shauke
previously approved these changes
Apr 22, 2024
shauke
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Component and directive prefixes are enforced to be
ish(and the prefix after successfully adding a customization), but not for pipes.What Is the New Behavior?
Pipe prefix is enforced with eslint rule.
Does this PR Introduce a Breaking Change?
[x] Yes
Other Information
BREAKING CHANGE: Pipes
sanitize,makeHrefandhtmlEncodeare renamed using anishprefix (see Migrations / From 5.1 to 5.2 for more details).AB#95722