feat(nginx): make worker_processes and worker_connections configurable
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
feature/nginx_worker_connections_worker_processes
branch
from
59a6b2d
to
803f977
Compare
andreassteinmann
previously approved these changes
Apr 17, 2024
dhhyi
requested changes
Apr 18, 2024
shauke
force-pushed
the
feature/nginx_worker_connections_worker_processes
branch
from
803f977
to
422ba0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
worker_processes autoandworker_connections 1024is currently hard coded in thenginx.confand cannot easily be changed via deployment.What Is the New Behavior?
nginx.confis changed to a gomplate template andworker_processesandworker_connectionsare now configurable via environment variablesNGINX_WORKER_PROCESSESandNGINX_WORKER_CONNECTIONS.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#95876