Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default theme also as default for override schematic #1637

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Apr 22, 2024

PR Type

[X] Feature

What Is the Current Behavior?

When adding a default theme with the customization starter script, the new theme is just added in front of the list of theme recommendations when using the override schematic.

What Is the New Behavior?

When adding a default theme, the list of recommended themes is replaced with the new theme.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

AB#96039

@dhhyi dhhyi added the feature New feature or request label Apr 22, 2024
@dhhyi dhhyi self-assigned this Apr 22, 2024
@dhhyi dhhyi added enhancement Enhancement to an existing feature nice to have Something that we can all live without, but will really improve a certain unimportant aspect and removed feature New feature or request labels Apr 23, 2024
@dhhyi dhhyi removed their assignment Apr 23, 2024
@dhhyi dhhyi marked this pull request as ready for review April 23, 2024 13:56
@shauke shauke added this to the 5.2 milestone Apr 26, 2024
@shauke shauke merged commit 4755c15 into develop Apr 26, 2024
24 checks passed
@shauke shauke deleted the feat/theme-override-default branch April 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature nice to have Something that we can all live without, but will really improve a certain unimportant aspect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants