refactor: lazy load variations #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
enhancement
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
BREAKING CHANGE: The variations property on the product view interface was removed. Variations can now be retrieved via the product context facade or the shopping facade.
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
BREAKING CHANGE: The productMaster property on the product view model has been removed. The master product should be individually retrieved.
dhhyi
force-pushed
the
refactor/lazy-variations
branch
from
cca5c22
to
39af869
Compare
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
BREAKING CHANGE: The variations property on the product view interface was removed. Variations can now be retrieved via the product context facade or the shopping facade.
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
dhhyi
added a commit
that referenced
this pull request
Apr 29, 2024
BREAKING CHANGE: The productMaster property on the product view model has been removed. The master product should be individually retrieved.
dhhyi
force-pushed
the
refactor/lazy-variations
branch
from
39af869
to
866d300
Compare
BREAKING CHANGE: The variations property on the product view interface was removed. Variations can now be retrieved via the product context facade or the shopping facade.
shauke
force-pushed
the
refactor/lazy-variations
branch
from
866d300
to
f4b2d41
Compare
shauke
pushed a commit
that referenced
this pull request
May 22, 2024
BREAKING CHANGE: The productMaster property on the product view model has been removed. The master product should be individually retrieved.
BREAKING CHANGE: The productMaster property on the product view model has been removed. The master product should be individually retrieved.
shauke
force-pushed
the
refactor/lazy-variations
branch
from
f4b2d41
to
0c13d96
Compare
shauke
pushed a commit
that referenced
this pull request
May 22, 2024
BREAKING CHANGE: The variations property on the product view interface was removed. Variations can now be retrieved via the product context facade or the shopping facade.
shauke
pushed a commit
that referenced
this pull request
May 22, 2024
shauke
pushed a commit
that referenced
this pull request
May 22, 2024
BREAKING CHANGE: The productMaster property on the product view model has been removed. The master product should be individually retrieved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Product variations are eagerly loaded via effects. In projects with a lot of Variations, this can lead to performance issues, especially if the variations data is not needed for the current views.
What Is the New Behavior?
Product variations are loaded lazily.
Does this PR Introduce a Breaking Change?
[X] Yes
[ ] No
Other Information
BREAKING CHANGE: The
variationsproperty on the product view interface was removed. Variations can now be retrieved via the product context facade or the shopping facade.AB#96195