Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case where all recently viewed products are failed/offline - improved #1647

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Apr 29, 2024

inspired by the mentioned solution from #1420

PR Type

[x] Bugfix

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#96234

@shauke shauke added this to the 5.2 milestone Apr 29, 2024
@shauke shauke self-assigned this Apr 29, 2024
@shauke shauke added the bug Something isn't working label Apr 29, 2024
@shauke shauke force-pushed the feature/failed_products_improvements branch from ce2f568 to f41e64d Compare April 29, 2024 17:37
Stefan Hauke and others added 2 commits April 30, 2024 10:05
… lists (used for recently viewed and wishlist improvements) (#1647)

* do not display the recently viewed headings and links if no available products are on the recently viewed list
* display the no items on list info for the wishlist widget if no available products are on the lists
* inspired by #1420

 Co-authored-by: Jan Joosse <j.joosse@rijkzwaan.nl>
@shauke shauke force-pushed the feature/failed_products_improvements branch from f41e64d to ed88605 Compare April 30, 2024 08:07
@shauke shauke merged commit 69f0caf into develop Apr 30, 2024
21 checks passed
@shauke shauke deleted the feature/failed_products_improvements branch April 30, 2024 09:31
shauke pushed a commit that referenced this pull request Apr 30, 2024
… lists (used for recently viewed and wishlist improvements) (#1647)

* do not display the recently viewed headings and links if no available products are on the recently viewed list
* display the no items on list info for the wishlist widget if no available products are on the lists
* inspired by #1420

 Co-authored-by: Jan Joosse <j.joosse@rijkzwaan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant