Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rework product-item-variations component #1648

Merged
merged 1 commit into from
May 22, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Apr 30, 2024

PR Type

[X] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

Logic in ish-product-item-variations is confusing.

What Is the New Behavior?

Refactored component to make it easier to understand and customize.

Does this PR Introduce a Breaking Change?

[X] Yes
[ ] No

Other Information

BREAKING CHANGE: The ish-product-item-variations component has been refactored.

AB#96248

@dhhyi dhhyi added the refactoring Refactoring of current code label Apr 30, 2024
@dhhyi dhhyi self-assigned this Apr 30, 2024
@dhhyi dhhyi changed the base branch from develop to refactor/lazy-variations April 30, 2024 08:59
@dhhyi dhhyi removed their assignment May 2, 2024
@dhhyi dhhyi marked this pull request as ready for review May 2, 2024 08:02
@shauke shauke added this to the 5.2 milestone May 10, 2024
@dhhyi dhhyi force-pushed the refactor/product-item-variations branch 2 times, most recently from 30592dc to 38112d4 Compare May 21, 2024 14:04
Base automatically changed from refactor/lazy-variations to develop May 22, 2024 12:17
@shauke shauke force-pushed the refactor/product-item-variations branch from 38112d4 to 19bdbae Compare May 22, 2024 13:56
@shauke shauke force-pushed the refactor/product-item-variations branch from 19bdbae to 3d3f15f Compare May 22, 2024 14:40
shauke
shauke previously approved these changes May 22, 2024
@shauke shauke force-pushed the refactor/product-item-variations branch from 3d3f15f to 4b553b3 Compare May 22, 2024 15:30
@shauke shauke merged commit 6ac30c3 into develop May 22, 2024
17 of 18 checks passed
@shauke shauke deleted the refactor/product-item-variations branch May 22, 2024 15:41
shauke pushed a commit that referenced this pull request May 23, 2024
BREAKING CHANGE: The `ish-product-item-variations` component has been refactored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants