ISREST-1006: add sepa component #165

skoch-intershop · 2020-03-18T08:40:38Z

PR Type

[x] Feature

requires CONCARDIS 1.7.2 release ( and an ICM release 7.10.16.6+ )

What Is the Current Behavior?

It is not possible to create a Concardis SEPA Direct Debit payment instrument on the checkout payment page.
Issue Number: ISREST-1006

What Is the New Behavior?

Creation of a Concardis SEPA Direct Debit payment instrument is possible on the checkout payment page.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

SGrueber · 2020-03-19T11:24:37Z

src/app/core/models/payment-method/hosted-payment-page-parameters.mapper.ts

@@ -0,0 +1,20 @@
+export class HostedPaymentPageParametersMapper {
+  static fromData(body: { name: string; value: string }[]): { name: string; value: string }[] {


if this method is only used by the payment-method.mapper it should be moved to the payment-method.mapper
test and a short documentation is missing,
it is not clear, if this is a specific method for concardis direct debit a generic functionality, why is it needed?

SGrueber · 2020-03-19T11:25:34Z

src/app/core/models/payment-method/hosted-payment-page-parameters.mapper.ts

+  static fromData(body: { name: string; value: string }[]): { name: string; value: string }[] {
+    const hostedPaymentPageParameters: { name: string; value: string }[] = new Array();
+
+    if (body !== undefined) {


if (body && body.length

SGrueber · 2020-03-19T11:30:27Z

src/app/core/models/payment-method/hosted-payment-page-parameters.mapper.ts

+    const hostedPaymentPageParameters: { name: string; value: string }[] = new Array();
+
+    if (body !== undefined) {
+      for (const entry of body) {


i think you can use map here,
hostedPaymentPageParameters = body.map ( entry => { do some mapping here);

if not let's talk, don't use push

SGrueber · 2020-03-19T11:37:33Z

src/app/pages/checkout-payment/checkout-payment/checkout-payment.component.html

-            </div></li
-        ></ng-container>
+            </div>
+          </li></ng-container


SGrueber · 2020-03-19T12:06:58Z

.../checkout-payment/payment-concardis-directdebit/payment-concardis-directdebit.component.html

@@ -0,0 +1,19 @@
+<formly-form [form]="parameterForm" [options]="options" [model]="model" [fields]="getFieldConfig()">
+  <div class="offset-md-4 col-md-8">


<div class="form-group">
is missing - padding at the bottom

SGrueber · 2020-03-19T13:58:38Z

...es/checkout-payment/payment-concardis-directdebit/payment-concardis-directdebit.component.ts

+   * gets a parameter value from payment method
+   * sets the general error message (key) if the parameter is not available
+   */
+  private getParamValue(name: string, errorMessage: string): string {


move method to a parent and make it protected

SGrueber · 2020-03-19T14:03:36Z

...es/checkout-payment/payment-concardis-directdebit/payment-concardis-directdebit.component.ts

+  /**
+   * determine errorMessages on the basis of the error code
+   */
+  getErrorMessage(code: number, fieldType: string, defaultMessage: string): string {


move to parent component

SGrueber · 2020-03-19T14:04:02Z

...es/checkout-payment/payment-concardis-directdebit/payment-concardis-directdebit.component.ts

+  /**
+   * cancel new payment instrument, hides and resets the parameter form
+   */
+  cancelNewPaymentInstrument() {


move to parent component

SGrueber · 2020-03-19T14:04:52Z

src/app/shared/forms-dynamic/components/checkbox-dynamic/checkbox-dynamic.component.html

@@ -0,0 +1,9 @@
+<div *ngIf="field.fieldGroupClassName" class="{{ field.fieldGroupClassName }}">
+  <ish-checkbox


<div class="form-group" is missing

SGrueber · 2020-03-19T14:13:58Z

src/assets/i18n/en_US.json

@@ -2679,5 +2679,17 @@
  "quote.already_in_basket.error": "The quote is already in the cart.",
  "quote.not_found.error": "The quote could not be found.",
  "basket.add_quote.error": "The quote could not be added to the cart.",
-  "quoterequest.not_editable.error": "You have already submitted the quote request. Please <a href=\"javascript:location.reload()\">reload</a> this page to view the changes."
+  "quoterequest.not_editable.error": "You have already submitted the quote request. Please <a href=\"javascript:location.reload()\">reload</a> this page to view the changes.",
+  "checkout.sepa.iban.error.default": "Field is required and should not be empty!",


pls, use existing error message keys, if possible, e.g. checkout.payment.debit.transfer.account.number.missing.error
if it is not possible for some keys, ask docu team for assistence and provide also German and French translations

src/app/core/models/payment-method/payment-method.mapper.ts

...app/pages/checkout-payment/checkout-payment/payment-concardis/payment-concardis.component.ts

…T-1006)

- requires CONCARDIS 1.7.2 release and an ICM release 7.10.16.6+

shauke · 2020-04-01T11:53:59Z

Changes cherry picked to 0.18.1 hotfix release branch (https://github.com/intershop/intershop-pwa/tree/chore/release_0.18.1). Will be released and merged via the hotfix branch.

- requires CONCARDIS 1.7.2 release and an ICM release 7.10.16.6+

shauke · 2020-04-01T21:05:57Z

Merged with 0.18.1 hotfix release changes in the develop branch (c0db224).

skoch-intershop requested a review from SGrueber March 18, 2020 08:41

dhhyi assigned SGrueber Mar 18, 2020

dhhyi added the feature New feature or request label Mar 18, 2020

SGrueber assigned skoch-intershop and SGrueber and unassigned SGrueber Mar 18, 2020

SGrueber requested changes Mar 19, 2020

View reviewed changes

skoch-intershop force-pushed the feature/add_concardis_sepa_component branch from cdb0045 to 117d994 Compare March 26, 2020 06:59

SGrueber force-pushed the feature/add_concardis_sepa_component branch 2 times, most recently from 04f4efb to 1c667e1 Compare March 31, 2020 09:29

SGrueber previously approved these changes Mar 31, 2020

View reviewed changes

skoch-intershop and others added 5 commits March 31, 2020 12:26

ISREST-1006: add sepa component

7ad7b7f

#IS-29682: corrected English texts and added localizations (for ISRES…

465983a

…T-1006)

ISREST-1006: adjust hosted payment page parameters mapping

8cf419d

feat: ISREST-1006 adjust payment component structure

d4a18b0

feat: concardis direct debit improvements

a9b2b37

SGrueber dismissed their stale review via a9b2b37 March 31, 2020 10:27

SGrueber force-pushed the feature/add_concardis_sepa_component branch from 1c667e1 to a9b2b37 Compare March 31, 2020 10:27

SGrueber approved these changes Mar 31, 2020

View reviewed changes

shauke pushed a commit that referenced this pull request Mar 31, 2020

feat: support Concardis Direct Debit payment method (#165)

a3b3e74

- requires CONCARDIS 1.7.2 release and an ICM release 7.10.16.6+

shauke pushed a commit that referenced this pull request Apr 1, 2020

feat: support Concardis Direct Debit payment method (#165)

567b61e

- requires CONCARDIS 1.7.2 release and an ICM release 7.10.16.6+

shauke closed this Apr 1, 2020

shauke deleted the feature/add_concardis_sepa_component branch April 14, 2020 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISREST-1006: add sepa component #165

ISREST-1006: add sepa component #165

skoch-intershop commented Mar 18, 2020 •

edited by SGrueber

Loading

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

SGrueber Mar 19, 2020

shauke commented Apr 1, 2020

shauke commented Apr 1, 2020

		@@ -0,0 +1,20 @@
		export class HostedPaymentPageParametersMapper {
		static fromData(body: { name: string; value: string }[]): { name: string; value: string }[] {

		@@ -0,0 +1,19 @@
		<formly-form [form]="parameterForm" [options]="options" [model]="model" [fields]="getFieldConfig()">
		<div class="offset-md-4 col-md-8">

		@@ -0,0 +1,9 @@
		<div *ngIf="field.fieldGroupClassName" class="{{ field.fieldGroupClassName }}">
		<ish-checkbox

ISREST-1006: add sepa component #165

ISREST-1006: add sepa component #165

Conversation

skoch-intershop commented Mar 18, 2020 • edited by SGrueber Loading

PR Type

What Is the Current Behavior?

What Is the New Behavior?

Does this PR Introduce a Breaking Change?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shauke commented Apr 1, 2020

shauke commented Apr 1, 2020

skoch-intershop commented Mar 18, 2020 •

edited by SGrueber

Loading