fix: wishlist and order templates title with special characters not displayed correct #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (e.g. ä,ö,ü) are not displayed correct
shauke
force-pushed
the
bugfix/special_characters_in_wishlist_title
branch
from
46e9f43 to
ce0c5ba
Compare
SGrueber
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
Wishlist and order templates titles with special characters (e.g. ä,ö,ü) are not displayed correct.
This is a result of PR #1551 that sanitizes potentially dangerous wishlist/order template titles coming from the REST API.
What Is the New Behavior?
The changes from #1551 where reverted to correctly display wishlist/order template titles.
The danger from self given titles for wishlists/order templates seems low compared to the strange rendering of special characters.
To prevent the only known place where possibly dangerous code is evaluated the
ishHtmlEncodepipe is used.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#96600