Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable SSR metrics granularity #1747

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Philipp-Borchert-ISH
Copy link

@Philipp-Borchert-ISH Philipp-Borchert-ISH commented Jan 31, 2025

PR Type

[x] Bugfix
[x] Feature

What Is the Current Behavior?

  • metrics are separated by path, pm2 id etc.

What Is the New Behavior?

  • metrics can now be configured via METRICS_DETAIL_LEVEL=DEFAULT|DETAILED
  • additionally a memory leak in the SSR process when PROMETHEUS=off has been fixed

Does this PR Introduce a Breaking Change?

[x] Yes

New default metrics format - previous behavior can be restored via configuration, see migration guide.

Other Information

AB#103635

Precondition for AB#102300

- also fixes a memory leak in SSR when PROMETHEUS=off
@Philipp-Borchert-ISH Philipp-Borchert-ISH added this to the 5.3 milestone Jan 31, 2025
@shauke shauke self-assigned this Feb 4, 2025
@shauke shauke self-requested a review February 4, 2025 10:01
@shauke shauke changed the title feat: configurable metrics granularity (#102300) feat: configurable SSR metrics granularity Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants