Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: sparque suggestion integration #1760

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

skoch-intershop
Copy link
Contributor

@skoch-intershop skoch-intershop commented Feb 24, 2025

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[x] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

Issue Number: #FEATURE 98700 (ADO)

What Is the New Behavior?

Introduction of the Sparque Autosuggest feature. The Solr auto suggestion still works and is set as default.

Does this PR Introduce a Breaking Change?

  • suggestion.model.ts is deleted => will replaced by suggestion.model.ts
  • suggest.service.ts is deleted => will replaced by icm-suggestion.service.ts
  • search-box.component.ts is deleted => will replaced by standalone component search-box.component.ts
  • changes in shared.module.ts, shell.module.ts and header-default.component.ts

[x] Yes
[ ] No

Other Information

skoch-intershop and others added 8 commits February 24, 2025 12:47
* feat: integrate sparque suggest service (#102332)

* feat: split search box component into solr and sparque components (#102332)

* feat: add docker compose files for icm/sparque environment (#102332)

* feat: transform sparque search box to standalone (#102611)

* feat: map sparque objects to common already existing models (#102934)
#1748)

* feat: separate terms, apply styling

* feat: enable tab navigation within suggest layer, remove arrow key navigation

* feat: add loading and error handling

* feat: update loading and error handling, check 2 character input

* feat: add clear suggestion, remove check for search box focus, fix standard suggest observable behavior

* fix: update effect

* fix: remove obsolate test cases

* feat: introduce only one search-box with tiles component (#103499)

* fix: correct naming, correct interaciton to hide suggest layer when no focus

* feat: no suggest on error and no-search-result page, remove not needed simple sarch box CSS, update comments

* fix: mobile display of suggest layer

* feat: basic layout for all elements, show categories, brands, products, "show all link"

* fix: mobile line-height

* feat: set count parameter for maximum results

* feat: adjust layout according to available suggestion types

* feat: show more products in one row if other suggests are not available

* feat: simplifing of search store (#103499)

* feat: fix failed test (#103499)

* feat: fix test compile error (#103499)

* feat: fix ci failures (#103499)

* feat: set token only in case user id is set as param (#103499)

* fix: lint failure

* fix: fix cyress tests (#103499)

* fix: fix dead code (#103499)

* fix: fix dead code (#103499)

* fix: fix dead code (#103499)

* fix: fix dead code (#103499)

* fix: remove not useful test (#103499)

* feat: show all elements based on available data from Sparque

* fix: dead code failure (#103399)

* fix: e2e test failure (#103399)

---------

Co-authored-by: Andreas Steinmann <asteinmann@intershop.com>
…ht (#1757)

* feat: show products below each other on mobile and tablet
* feat: truncate product name only on desktop
* feat: add accessibility attributes
* feat: set suggest layer max-height on mobile dynamically depending on onscreen keyboard height
* feat: update suggest layer max-height for desktop
…nput (#1758)

* the product price will not be shown
* the product image not available is shown in case the product image attribute es empty
* the minimum character count to show the suggest is changed from 2 to 3
@skoch-intershop skoch-intershop force-pushed the feature/sparque_integration branch from ad32a9a to 76f8c72 Compare February 24, 2025 11:48
@skoch-intershop skoch-intershop changed the title Feature/sparque integration feature: sparque suggestion integration Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants