-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: sparque suggestion integration #1760
Open
skoch-intershop
wants to merge
9
commits into
develop
Choose a base branch
from
feature/sparque_integration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: integrate sparque suggest service (#102332) * feat: split search box component into solr and sparque components (#102332) * feat: add docker compose files for icm/sparque environment (#102332) * feat: transform sparque search box to standalone (#102611) * feat: map sparque objects to common already existing models (#102934)
#1748) * feat: separate terms, apply styling * feat: enable tab navigation within suggest layer, remove arrow key navigation * feat: add loading and error handling * feat: update loading and error handling, check 2 character input * feat: add clear suggestion, remove check for search box focus, fix standard suggest observable behavior * fix: update effect * fix: remove obsolate test cases * feat: introduce only one search-box with tiles component (#103499) * fix: correct naming, correct interaciton to hide suggest layer when no focus * feat: no suggest on error and no-search-result page, remove not needed simple sarch box CSS, update comments * fix: mobile display of suggest layer * feat: basic layout for all elements, show categories, brands, products, "show all link" * fix: mobile line-height * feat: set count parameter for maximum results * feat: adjust layout according to available suggestion types * feat: show more products in one row if other suggests are not available * feat: simplifing of search store (#103499) * feat: fix failed test (#103499) * feat: fix test compile error (#103499) * feat: fix ci failures (#103499) * feat: set token only in case user id is set as param (#103499) * fix: lint failure * fix: fix cyress tests (#103499) * fix: fix dead code (#103499) * fix: fix dead code (#103499) * fix: fix dead code (#103499) * fix: fix dead code (#103499) * fix: remove not useful test (#103499) * feat: show all elements based on available data from Sparque * fix: dead code failure (#103399) * fix: e2e test failure (#103399) --------- Co-authored-by: Andreas Steinmann <asteinmann@intershop.com>
…ht (#1757) * feat: show products below each other on mobile and tablet * feat: truncate product name only on desktop * feat: add accessibility attributes * feat: set suggest layer max-height on mobile dynamically depending on onscreen keyboard height * feat: update suggest layer max-height for desktop
…nput (#1758) * the product price will not be shown * the product image not available is shown in case the product image attribute es empty * the minimum character count to show the suggest is changed from 2 to 3
ad32a9a
to
76f8c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[x] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
Issue Number: #FEATURE 98700 (ADO)
What Is the New Behavior?
Introduction of the Sparque Autosuggest feature. The Solr auto suggestion still works and is set as default.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information