feat: secure forms with a captcha according to the ICM server settings #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
feature/captcha_server_configuration
branch
2 times, most recently
from
81b03b1
to
d4ea9a5
Compare
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
6 times, most recently
from
115719e
to
5b3c641
Compare
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
3 times, most recently
from
a2d7886
to
a966eb1
Compare
dhhyi
pushed a commit
that referenced
this pull request
May 18, 2020
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
…service (#200) - introduces lazy components for captcha - use temporary feature toggle 'noCaptcha' to disable captchas in PWA (server API bug) BREAKING CHANGE: feature toggles captchaV2 and captchaV3 are obsolete
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
a966eb1
to
8bfc9d3
Compare
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
a893be6
to
7aa2a93
Compare
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
7aa2a93
to
5181417
Compare
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
dhhyi
added a commit
that referenced
this pull request
May 18, 2020
… related ICM captcha service (#200)
shauke
previously approved these changes
May 22, 2020
dhhyi
pushed a commit
that referenced
this pull request
May 24, 2020
dhhyi
added a commit
that referenced
this pull request
May 24, 2020
dhhyi
added a commit
that referenced
this pull request
May 24, 2020
…service (#200) - introduces lazy components for captcha BREAKING CHANGE: feature toggles captchaV2 and captchaV3 are obsolete component ish-captcha is replaced by ish-lazy-captcha with mandatory topic input
dhhyi
added a commit
that referenced
this pull request
May 24, 2020
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
50c291b
to
799ba7b
Compare
dhhyi
added a commit
that referenced
this pull request
May 24, 2020
…service (#200) - introduces lazy components for captcha BREAKING CHANGE: feature toggles captchaV2 and captchaV3 are obsolete component ish-captcha is replaced by ish-lazy-captcha with mandatory topic input
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
612a876
to
1e8acd1
Compare
dhhyi
added a commit
that referenced
this pull request
May 24, 2020
…service (#200) - introduces lazy components for captcha BREAKING CHANGE: feature toggles captchaV2 and captchaV3 are obsolete component ish-captcha is replaced by ish-lazy-captcha with mandatory topic input
dhhyi
force-pushed
the
feature/captcha_server_configuration
branch
from
0d1a2ab
to
127e4af
Compare
dhhyi
approved these changes
May 24, 2020
SGrueber
added a commit
that referenced
this pull request
May 25, 2020
SGrueber
pushed a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
In dependence of the PWA environment settings some forms (registration, forgot password, contact us) are secured with a captcha (V2 or V3)
If in the ICM server configuration there is a different captcha service activated than in the environment properties of the PWA requests might finish with errors.
Issue Number: Closes #196
What Is the New Behavior?
The ICM captcha configuration determines whether and which captcha component is used to secure the forms. The captcha settings in the environment.properties are no longer used.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Remove captcha settings from environment.properties.
Other Information