refactor: cleanup state #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
2 times, most recently
from
0c80416 to
790a062
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
2 times, most recently
from
2c5ae73 to
5c33a95
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
d190efc to
012ec05
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
from
5c33a95 to
96dbb6a
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
012ec05 to
b6421bf
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
from
96dbb6a to
101a810
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
94f7c05 to
fc6dc45
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
from
101a810 to
8ada488
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
3 times, most recently
from
ab09b12 to
40bcebf
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
from
8ada488 to
d934f93
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
40bcebf to
fdeb386
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
from
d934f93 to
ecea3db
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
fdeb386 to
de0fd9d
Compare
dhhyi
force-pushed
the
refactor/ngrx-testing
branch
2 times, most recently
from
c8e3626 to
e98f1c1
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
6 times, most recently
from
60bff66 to
4166f1f
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
7bb5b39 to
d391ff4
Compare
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
d391ff4 to
25ace4f
Compare
MWallnisch
previously approved these changes
Jun 9, 2020
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
ee6052a to
ef32adf
Compare
BREAKING CHANGE: Core store was restructured. Follow instructions in the migration guide.
dhhyi
force-pushed
the
refactor/cleanup-core-state
branch
from
ef32adf to
b6557b3
Compare
shauke
approved these changes
Jun 15, 2020
dhhyi
added a commit
that referenced
this pull request
Feb 26, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Feb 26, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Feb 26, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Mar 3, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Apr 18, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Apr 18, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
added a commit
that referenced
this pull request
Apr 18, 2021
- needed for access to locale setting of ICM in core configuration state - relates to #227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Core State has many substates that could be grouped together.
What Is the New Behavior?
grouping
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No