Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ngrx/entity in quoting feature #25

Merged
merged 1 commit into from
Dec 10, 2019
Merged

refactor: use ngrx/entity in quoting feature #25

merged 1 commit into from
Dec 10, 2019

Conversation

fmalcher
Copy link
Collaborator

@fmalcher fmalcher commented Nov 28, 2019 •
edited
Loading

This is the starting point for the quoting refactoring.

First steps done:

  • Use ngrx/entity for quotes and quote requests
  • Refactor selectors to be easier to reason about

@shauke shauke added the enhancement Enhancement to an existing feature label Dec 3, 2019
@shauke shauke merged commit f237186 into develop Dec 10, 2019
@shauke shauke deleted the refactoring/quoting branch December 10, 2019 08:39
@shauke shauke added this to the 0.17 milestone Dec 10, 2019
shauke pushed a commit that referenced this pull request Dec 13, 2019
@fmalcher @shauke
refactor: use ngrx/entity in quoting feature (#25)
70102d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebastian-Haehnlein Sebastian-Haehnlein Sebastian-Haehnlein approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@fmalcher @Sebastian-Haehnlein @shauke