Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorization Toggles #298

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Authorization Toggles #298

merged 5 commits into from
Jul 6, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jun 24, 2020 •
edited
Loading

PR Type

[x] Feature
[x] Refactoring (no functional changes, no API changes)

What Is the New Behavior?

  • retrieve user roles and permission for logged in user
  • guard, directives and service for toggling storefront functionality depending on the current users permissions

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

  • required ICM 7.10.20+ GA

@dhhyi dhhyi added the feature New feature or request label Jun 24, 2020
@dhhyi dhhyi added this to the 0.22 milestone Jun 24, 2020
@dhhyi dhhyi self-assigned this Jun 24, 2020
@dhhyi dhhyi added the wait Waiting for something (e.g. new ICM release) label Jun 26, 2020
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from 43bee18 to cfdb620 Compare June 30, 2020 15:27
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: retrieve roles and permissions for B2B users (#298)
fdaf2ff
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
f3ffec1 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
056d466
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
19c2842 
…298)
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from cfdb620 to 19c2842 Compare July 1, 2020 07:33
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
76e8602 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
5a63c39
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from 19c2842 to d321bd5 Compare July 1, 2020 07:56
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
d321bd5 
…298)
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
3ca58ea 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
2c90f31
dhhyi added a commit that referenced this pull request Jul 1, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
7b5cbc8 
…298)
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from d321bd5 to 7b5cbc8 Compare July 1, 2020 08:19
@dhhyi dhhyi marked this pull request as ready for review July 1, 2020 08:51
@dhhyi dhhyi removed the wait Waiting for something (e.g. new ICM release) label Jul 1, 2020
@shauke shauke self-requested a review July 1, 2020 12:58
dhhyi added a commit that referenced this pull request Jul 2, 2020
@dhhyi
feat: retrieve roles and permissions for B2B users (#298)
b0dd161
dhhyi added a commit that referenced this pull request Jul 2, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
bbf6c8d 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 2, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
9b3337b
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from 7b5cbc8 to 62496e4 Compare July 2, 2020 07:09
dhhyi added a commit that referenced this pull request Jul 2, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
62496e4 
…298)
dhhyi added a commit that referenced this pull request Jul 3, 2020
@dhhyi
feat: retrieve roles and permissions for B2B users (#298)
02e8c1c
dhhyi added a commit that referenced this pull request Jul 3, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
da97381 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 3, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
6e8336e
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from 62496e4 to 2bafa3d Compare July 3, 2020 05:19
dhhyi added a commit that referenced this pull request Jul 3, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
2bafa3d 
…298)
shauke
shauke requested changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look at the account-user-info.component.html styling. There is a hover effect that should not be there.

src/app/pages/account/account-navigation/account-navigation.component.html Outdated Show resolved Hide resolved
src/app/pages/account/account-navigation/account-navigation.component.html Outdated Show resolved Hide resolved
src/app/pages/account/account-navigation/account-navigation.component.ts Show resolved Hide resolved
src/app/pages/account/account-user-info/account-user-info.component.html Outdated Show resolved Hide resolved
dhhyi added a commit that referenced this pull request Jul 3, 2020
@dhhyi
feat: display information for B2B users above my account navigation (#…
2362b21 
…298)
@dhhyi dhhyi force-pushed the feature/authorization-toggles branch from 2bafa3d to 2362b21 Compare July 3, 2020 20:36
@dhhyi dhhyi requested a review from shauke July 3, 2020 21:21
@shauke shauke force-pushed the feature/authorization-toggles branch from 2362b21 to 1add78c Compare July 6, 2020 13:08
@shauke
Copy link
Collaborator

shauke commented Jul 6, 2020

The user info hover effect is removed - according to the changed IAD.

@dhhyi dhhyi merged commit ee5e1cb into develop Jul 6, 2020
dhhyi added a commit that referenced this pull request Jul 6, 2020
@dhhyi
feat: retrieve roles and permissions for B2B users (#298)
e4ba676
@dhhyi dhhyi deleted the feature/authorization-toggles branch July 6, 2020 14:07
dhhyi added a commit that referenced this pull request Jul 6, 2020
@dhhyi
feat: add guard, directive and service for toggling depending on user…
af9ce44 
… permissions (#298)
dhhyi added a commit that referenced this pull request Jul 6, 2020
@dhhyi
chore: allow user management functionality only for user managers (#298)
69e072f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees

@dhhyi dhhyi

@shauke shauke

Labels
feature New feature or request
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @shauke