-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for the new ICM headless Application Type 'intershop.REST' #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c72555
to
af6ad69
Compare
Clean up commits and commit messages and consider the comment in #303 in regards to the dialog changes |
af6ad69
to
e8a023d
Compare
Commits cleaned up and prepared for merging. |
dhhyi
pushed a commit
that referenced
this pull request
Jul 27, 2020
…w headless REST application type applications (#302) - change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-' - adapt demo content naming changes for the new applications (homepage include) BREAKING CHANGE: Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
dhhyi
pushed a commit
that referenced
this pull request
Jul 27, 2020
…del (#302) - rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm' BREAKING CHANGE: The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi
pushed a commit
that referenced
this pull request
Jul 27, 2020
…emo content (#302) - adapt references to changed system manged dialogs and pages BREAKING CHANGE: The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi
pushed a commit
that referenced
this pull request
Jul 27, 2020
e8a023d
to
b46a433
Compare
dhhyi
added a commit
that referenced
this pull request
Jul 27, 2020
… the new headless REST application type applications (#302)
dhhyi
added a commit
that referenced
this pull request
Jul 27, 2020
… application and customer type (#302)
dhhyi
added a commit
that referenced
this pull request
Jul 27, 2020
… the new headless REST application type applications (#302)
SGrueber
previously approved these changes
Jul 28, 2020
BREAKING CHANGE: Required ICM Version: 7.10.21.0
…w headless REST application type applications (#302) - change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-' - adapt demo content naming changes for the new applications (homepage include) BREAKING CHANGE: Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
…del (#302) - rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm' BREAKING CHANGE: The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
…emo content (#302) - adapt references to changed system manged dialogs and pages BREAKING CHANGE: The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
6bb94b8
to
0a811c8
Compare
dhhyi
pushed a commit
that referenced
this pull request
Jul 28, 2020
…w headless REST application type applications (#302) - change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-' - adapt demo content naming changes for the new applications (homepage include) BREAKING CHANGE: Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
dhhyi
pushed a commit
that referenced
this pull request
Jul 28, 2020
…del (#302) - rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm' BREAKING CHANGE: The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi
pushed a commit
that referenced
this pull request
Jul 28, 2020
…emo content (#302) - adapt references to changed system manged dialogs and pages BREAKING CHANGE: The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Support for the new ICM headless Application Type (intershop.REST) introduced wit ICM 7.10.21.0 instead of using the legacy application types (intershp.B2CResponsive, intershop.SMBResponsive) of the Responsive Starter Store.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Using a different CMS content model.
(Needs to be reverted if the PWA is to be used with the Responsive Starter Store, e.g in a Hybrid Approach)
Other Information
Wait for ICM 7.10.21.0
Closes #273