Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for the new ICM headless Application Type 'intershop.REST' #302

Merged
merged 6 commits into from
Jul 28, 2020

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Jun 26, 2020

PR Type

Support for the new ICM headless Application Type (intershop.REST) introduced wit ICM 7.10.21.0 instead of using the legacy application types (intershp.B2CResponsive, intershop.SMBResponsive) of the Responsive Starter Store.

Does this PR Introduce a Breaking Change?

[x] Yes
[ ] No

Using a different CMS content model.
(Needs to be reverted if the PWA is to be used with the Responsive Starter Store, e.g in a Hybrid Approach)

Other Information

Wait for ICM 7.10.21.0
Closes #273

@shauke shauke added feature New feature or request wait Waiting for something (e.g. new ICM release) labels Jun 26, 2020
@shauke shauke added this to the 0.23 milestone Jun 26, 2020
@shauke shauke requested a review from SGrueber June 26, 2020 06:57
@shauke shauke self-assigned this Jun 26, 2020
@shauke shauke force-pushed the feature/pwa_application_type branch from 4c72555 to af6ad69 Compare July 2, 2020 15:07
@shauke
Copy link
Collaborator Author

shauke commented Jul 2, 2020

Clean up commits and commit messages and consider the comment in #303 in regards to the dialog changes

@shauke shauke force-pushed the feature/pwa_application_type branch from af6ad69 to e8a023d Compare July 3, 2020 08:20
@shauke
Copy link
Collaborator Author

shauke commented Jul 3, 2020

Commits cleaned up and prepared for merging.

@shauke shauke marked this pull request as ready for review July 6, 2020 16:05
@shauke shauke requested a review from dhhyi July 6, 2020 16:05
dhhyi pushed a commit that referenced this pull request Jul 27, 2020
…w headless REST application type applications (#302)

- change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-'
- adapt demo content naming changes for the new applications (homepage include)

BREAKING CHANGE:
Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
dhhyi pushed a commit that referenced this pull request Jul 27, 2020
…del (#302)

- rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm'

BREAKING CHANGE:
The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi pushed a commit that referenced this pull request Jul 27, 2020
…emo content (#302)

- adapt references to changed system manged dialogs and pages

BREAKING CHANGE:
The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi pushed a commit that referenced this pull request Jul 27, 2020
@dhhyi dhhyi force-pushed the feature/pwa_application_type branch from e8a023d to b46a433 Compare July 27, 2020 18:09
dhhyi added a commit that referenced this pull request Jul 27, 2020
… the new headless REST application type applications (#302)
dhhyi added a commit that referenced this pull request Jul 27, 2020
dhhyi added a commit that referenced this pull request Jul 27, 2020
dhhyi added a commit that referenced this pull request Jul 27, 2020
dhhyi added a commit that referenced this pull request Jul 27, 2020
… the new headless REST application type applications (#302)
@dhhyi dhhyi self-assigned this Jul 27, 2020
@dhhyi dhhyi removed the wait Waiting for something (e.g. new ICM release) label Jul 27, 2020
SGrueber
SGrueber previously approved these changes Jul 28, 2020
dhhyi and others added 3 commits July 28, 2020 12:08
BREAKING CHANGE: Required ICM Version: 7.10.21.0
…w headless REST application type applications (#302)

- change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-'
- adapt demo content naming changes for the new applications (homepage include)

BREAKING CHANGE:
Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
shauke and others added 3 commits July 28, 2020 12:08
…del (#302)

- rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm'

BREAKING CHANGE:
The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
…emo content (#302)

- adapt references to changed system manged dialogs and pages

BREAKING CHANGE:
The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
@dhhyi dhhyi force-pushed the feature/pwa_application_type branch from 6bb94b8 to 0a811c8 Compare July 28, 2020 10:09
@dhhyi dhhyi merged commit 04abd41 into develop Jul 28, 2020
dhhyi pushed a commit that referenced this pull request Jul 28, 2020
…w headless REST application type applications (#302)

- change PWA default environment configuration to use the ICM demo content 'rest' applications instead of '-'
- adapt demo content naming changes for the new applications (homepage include)

BREAKING CHANGE:
Default environment configuration switched to the new headless 'rest' application in the ICM demo content (requires ICM version 7.10.21.0).
dhhyi pushed a commit that referenced this pull request Jul 28, 2020
…del (#302)

- rename resource set references from 'app_sf_responsive_cm' to 'app_sf_base_cm'

BREAKING CHANGE:
The PWA now uses the ICM CMS content model of the new headless 'rest' application (requires ICM version 7.10.21.0).
dhhyi pushed a commit that referenced this pull request Jul 28, 2020
…emo content (#302)

- adapt references to changed system manged dialogs and pages

BREAKING CHANGE:
The PWA now uses the ICM CMS demo content of the new headless 'rest' application (requires ICM version 7.10.21.0).
@dhhyi dhhyi deleted the feature/pwa_application_type branch July 28, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt customer REST calls to the new app type
3 participants