feat: Implement save for later checkbox for Direct Debit #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowiish
requested changes
Jul 13, 2020
SGrueber
requested changes
Jul 14, 2020
.../checkout-payment/payment-concardis-directdebit/payment-concardis-directdebit.component.html
Outdated
Show resolved
Hide resolved
|
The highlighted text (see pull request description) should not be displayed this way on the myAccount payment page. Pls remove it, or discuss the IAD. |
SGrueber
approved these changes
Jul 16, 2020
rowiish
approved these changes
Jul 16, 2020
rinkeshrsys
added a commit
to rinkeshrsys/intershop-pwa
that referenced
this pull request
Sep 22, 2020
rinkeshrsys
added a commit
to rinkeshrsys/intershop-pwa
that referenced
this pull request
Sep 22, 2020
This reverts commit a1a74af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Save for later checkbox was not available for Concardis direct debit.
What Is the New Behavior?
Save for later checkbox is visible and working for Concardis direct debit.
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
Requires Concardis Payment Connector 1.11.x - still unreleased