-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce product context #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5076a6c
to
d8c8538
Compare
8460219
to
eb1bb13
Compare
eb1bb13
to
13d5fd6
Compare
063bd89
to
0e4b507
Compare
1445d7c
to
eb07a18
Compare
785bfe2
to
20b534d
Compare
b8bf25e
to
1263cda
Compare
6f554c9
to
6d387f9
Compare
49b2c1e
to
795953c
Compare
ad6a6ba
to
12ab907
Compare
M-Behr
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool new quantity component. I like it.
Behavior issues:
- If you have a product in the cart and you enter 0 in quantity field or use the arrow, the product is removed. The new component displays an error message in this case. It is possible to enter 0 or use the "-" button to remove the product from the cart?
- The quantity field is very large in phone or tablet view on some pages. It think width: 50% is fine for the smaller breakpoints, where the component has the whole line or we can define a max. width for the component (maybe 165px - component size in product detail page)?
Some styling issues:
- The left border of the focus effect is missing in the cart => This only appears in the cart, maybe it is not a component issue?
- Space is missing between quantity component and add to cart (wish list page).
- A blank character is missing after product attribute label in the product list component for variation products.
- The variation product attributes have 8px margin between them. Please remove it, so that the attributes are grouped together.
Note: I saw that the font color of the product variation attributes was changed from 444 to 999. This is fine for @iwiederhold and me.
11 tasks
41eedcb
to
26d0385
Compare
84de78b
to
886e6cf
Compare
dhhyi
added a commit
that referenced
this pull request
Jan 29, 2021
BREAKING CHANGE: refactoring the way product specific components retrieve data with context facade
886e6cf
to
3f65120
Compare
6fd14cb
to
e6ec72d
Compare
dhhyi
added a commit
that referenced
this pull request
Jan 29, 2021
BREAKING CHANGE: refactoring the way product specific components retrieve data with context facade
3f65120
to
c1b5ddc
Compare
dhhyi
added a commit
to dhhyi/intershop-pwa-testing-workshop
that referenced
this pull request
Jan 29, 2021
BREAKING CHANGE: refactoring the way product specific components retrieve data with context facade
BREAKING CHANGE: refactoring the way product specific components retrieve data with context facade
c1b5ddc
to
95c7cca
Compare
Co-authored-by: Marcus Schmidt <MarSchmidt@intershop.com>
e669d67
to
24b7ed0
Compare
shauke
approved these changes
Jan 30, 2021
shauke
pushed a commit
that referenced
this pull request
Jan 30, 2021
BREAKING CHANGE: refactoring the way product specific components retrieve data with context facade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Application / infrastructure changes
What Is the Current Behavior?
Component composition also includes bubbling of data and events that could be handled by contexts for products.
What Is the New Behavior?
Major refactoring:
-> less logic in templates, components
Still open for later:
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No