Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair setting of canonical urls and other meta data #412

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Oct 9, 2020

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number: Closes #406

What Is the New Behavior?

seo.effects reworked.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the bug Something isn't working label Oct 9, 2020
@dhhyi dhhyi added this to the 0.25 milestone Oct 9, 2020
@dhhyi dhhyi self-assigned this Oct 9, 2020
@dhhyi dhhyi force-pushed the fix/canonical-url branch 3 times, most recently from 739428b to 0f28550 Compare October 9, 2020 18:21
@dhhyi dhhyi force-pushed the fix/canonical-url branch from 0f28550 to 6a48795 Compare October 9, 2020 18:53
@dhhyi dhhyi marked this pull request as ready for review October 9, 2020 19:37
@dhhyi dhhyi requested a review from shauke October 12, 2020 08:26
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The canonical URLs are pretty stable.

@dhhyi dhhyi merged commit 05e54c0 into develop Oct 12, 2020
@dhhyi dhhyi deleted the fix/canonical-url branch October 12, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Canonical URL
2 participants