Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submit a promotion code by pressing enter #436

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 22, 2020

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If the user presses enter in the promotion code input on the cart page the add-to-wishlist or add-to-order-template dialog opens up.

Issue Number: Closes #433

What Is the New Behavior?

If the user presses enter in the promotion code input on the cart page the promotion code is submitted.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber self-assigned this Oct 22, 2020
@SGrueber SGrueber added the bug Something isn't working label Oct 22, 2020
@SGrueber SGrueber added this to the 0.25 milestone Oct 22, 2020
Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works perfectly

@M-Behr M-Behr self-requested a review October 26, 2020 08:17
@SGrueber SGrueber merged commit 360b649 into develop Oct 26, 2020
@SGrueber SGrueber deleted the bugfix/enter_promotion_code_form branch October 26, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submitting promotion code opens "Add to wish list" / "Add to order template" dialog
3 participants