fix: replace interfering special characters from product and categoy slugs #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
bugfix/url-slug-improvements
branch
from
c74142d to
4fe50fb
Compare
dhhyi
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
Under certain circumstances product slugs that are intended to make product routes more "speaking" and better suited for SEO can interfere with other PWA functionality (e.g the multi-site handling) if they contain some special characters in the route/URL.
The current filtering of " ", "(" and ")" was extended with "&" and the whole configuration was centralized in one place and consistently used for product and category slugs.
If projects need further filtering, e.g. there have been issues with "/" for some projects, these additional characters can now be added at a single place.
Does this PR Introduce a Breaking Change?
[x] Yes - in regards to the current ICM-PWA site map implementation adaptions will be needed.