Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/duplicate payment instrument message #491

Conversation

harshrsys
Copy link
Contributor

PR Type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

-wrong Localized message is shown for duplicate payment instrument in case of saved cards.
-code breaks when multiple errors are received while creating payment instrument

What Is the New Behavior?

-correct Localized message is shown for duplicate payment instrument in case of saved cards.
-in case of multiple errors while creating payment instrument, only first error code is returned by handler.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

@shauke shauke added this to the 0.27 milestone Jan 4, 2021
@shauke shauke requested a review from SGrueber January 4, 2021 10:13
@SGrueber SGrueber assigned harshrsys and unassigned SGrueber Jan 4, 2021
@SGrueber SGrueber merged commit 2c54961 into intershop:develop Jan 4, 2021
@harshrsys harshrsys deleted the bugfix/duplicate-payment-instrument-message branch March 8, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants