Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: devcontainer for VSCode #515

Merged
merged 5 commits into from
Feb 5, 2021
Merged

feat: devcontainer for VSCode #515

merged 5 commits into from
Feb 5, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 28, 2021

PR Type

[x] Feature

What Is the New Behavior?

  • providing a devcontainer with VSCode

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Tested on

  • Docker for Windows with WSL2 backend
  • Ubuntu
  • Docker for Windows

Resources

VSCode Youtube - A Clean Dev Env, Working Every Time, Everywhere
VSCode Youtube - Remote Development with Visual Studio Code

@dhhyi dhhyi added the feature New feature or request label Jan 28, 2021
@dhhyi dhhyi self-assigned this Jan 28, 2021
@dhhyi dhhyi force-pushed the feature/devcontainer branch 3 times, most recently from 5a1c021 to de4c5ba Compare January 31, 2021 15:35
@dhhyi dhhyi marked this pull request as ready for review January 31, 2021 16:19
@dhhyi dhhyi requested review from shauke and jometzner January 31, 2021 16:19
@dhhyi dhhyi force-pushed the feature/devcontainer branch from de4c5ba to 4826c0c Compare February 1, 2021 09:15
@jometzner
Copy link
Collaborator

Hashtag VSCodeDay2021 ? 😃

@dhhyi dhhyi added this to the 0.28 milestone Feb 1, 2021
@jometzner
Copy link
Collaborator

When building the container, step 3 installing the angular/cli is asking for approval to collect anonymous data. Unfortunately there is no keyboard input possible. Did you guys had the same problem?

STEP 3: RUN sudo -u node npm install -g @angular/cli
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
/usr/local/share/npm-global/bin/ng -> /usr/local/share/npm-global/lib/node_modules/@angular/cli/bin/ng

> @angular/cli@11.1.2 postinstall /usr/local/share/npm-global/lib/node_modules/@angular/cli
> node ./bin/postinstall/script.js

? Would you like to share anonymous usage data with the Angular Team at Google u
nder
Google’s Privacy Policy at https://policies.google.com/privacy? For more details
 and
how to change this setting, see http://angular.io/analytics. (y/N) 

@dhhyi dhhyi force-pushed the feature/devcontainer branch from 4826c0c to d816fe4 Compare February 4, 2021 16:46
@dhhyi
Copy link
Collaborator Author

dhhyi commented Feb 4, 2021

node ./bin/postinstall/script.js

@jometzner I added --ignore-scripts to the CLI install, which should deactivate this. Please try again 😉

@jometzner
Copy link
Collaborator

node ./bin/postinstall/script.js

@jometzner I added --ignore-scripts to the CLI install, which should deactivate this. Please try again

Yes, it works. Thanks Dan!

shauke
shauke previously approved these changes Feb 4, 2021
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided some documentation "improvements". ;)

@dhhyi dhhyi requested a review from marschmidt89 February 4, 2021 20:50
@dhhyi dhhyi merged commit 7b3d937 into develop Feb 5, 2021
@dhhyi dhhyi deleted the feature/devcontainer branch February 5, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants