Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth0 silentRefresh requires offline_access scope #644

Merged
merged 1 commit into from
May 3, 2021

Conversation

franciscomdrito
Copy link
Contributor

@franciscomdrito franciscomdrito commented Apr 1, 2021

@franciscomdrito franciscomdrito requested a review from dhhyi April 1, 2021 20:09
dhhyi
dhhyi previously approved these changes Apr 2, 2021
@dhhyi dhhyi added the bug Something isn't working label Apr 2, 2021
@MaxKless MaxKless removed their assignment Apr 6, 2021
@jometzner
Copy link
Collaborator

jometzner commented Apr 7, 2021

Weird thing is that we currently only use the ID token to authenticate against REST resources. I thought that's the job of the Access token. Am I missing something?

@dhhyi
Copy link
Collaborator

dhhyi commented Apr 9, 2021

Weird thing is that we currently only use the ID token to authenticate against REST resources. I thought that's the job of the Access token. Am I missing something?

You are right. The angular-oauth2-oidc library also provides an automatism to send access_token, but the ICM has different requirements.

@shauke shauke added this to the 0.30 milestone May 3, 2021
@jometzner
Copy link
Collaborator

I double checked this issue on my demo setup with auth0.com acting as OIDC backend.

  1. Changed ID Token expiration time to 5 min
  2. Logged in
  3. Waited 5 minutes
  4. Saw the depicted behavior
    My Account | Intershop PWA - Vivaldi_031
    Selection_032

@jometzner jometzner force-pushed the fix/auth0-add-offline-access-scope branch from 93e9004 to be1f199 Compare May 3, 2021 08:57
@jometzner jometzner merged commit c6850a7 into develop May 3, 2021
@jometzner jometzner deleted the fix/auth0-add-offline-access-scope branch May 3, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants