fix: display a product unavailable image on product detail page #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
bugfix/unavailable_image_on_product_detail_page
branch
from
736bb7d to
e15bf7e
Compare
shauke
previously approved these changes
Apr 16, 2021
…here are no product images
SGrueber
force-pushed
the
bugfix/unavailable_image_on_product_detail_page
branch
from
e15bf7e to
60b6f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
If the product has no product images of size 'L' there is no product image displayed on product detail page.
What Is the New Behavior?
A fallback product image (not_available.png) is shown
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
see ISREST-1168