Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: individual page sizes for listings #709

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented May 27, 2021

PR Type

[x] Feature

What Is the Current Behavior?

Only one page size can be set for all master-page, category-page and search-page listings.

What Is the New Behavior?

Page sizes for listings of master-page, category-page and search-page can also be set individually.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi self-assigned this May 27, 2021
@dhhyi dhhyi added the enhancement Enhancement to an existing feature label May 27, 2021
@dhhyi dhhyi force-pushed the feature/individual-page-size-for-listings branch from a7224a3 to 936b81c Compare May 27, 2021 15:51
@dhhyi dhhyi marked this pull request as ready for review May 27, 2021 16:25
@dhhyi dhhyi requested a review from shauke June 3, 2021 21:07
@dhhyi dhhyi removed their assignment Jun 3, 2021
@shauke shauke self-assigned this Jun 7, 2021
@shauke shauke added this to the 0.32 milestone Jun 7, 2021
@shauke shauke force-pushed the feature/individual-page-size-for-listings branch 2 times, most recently from 6f7d6ed to cea55b0 Compare June 11, 2021 14:23
shauke
shauke previously approved these changes Jun 11, 2021
@shauke shauke force-pushed the feature/individual-page-size-for-listings branch from cea55b0 to fc94095 Compare June 11, 2021 14:46
@shauke shauke merged commit e6d41ca into develop Jun 11, 2021
@shauke shauke deleted the feature/individual-page-size-for-listings branch June 11, 2021 21:32
@shauke
Copy link
Collaborator

shauke commented Jun 14, 2021

@dhhyi Thank you for this nice feature as well. I merged it with different item sizes per page for category listings, search results and the variations listing by default to profit from the improvements and to showcase this improvement. 👍

default configuration in environment.model.ts

  productListingItemsPerPage: {
    category: 9,
    search: 12,
    master: 6,
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants