feat: replace i18nPlural pipe usage with translate compiler #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
feature/translations-plural
branch
4 times, most recently
from
a741ef0 to
f6fa86e
Compare
MaxKless
reviewed
Jun 7, 2021
dhhyi
force-pushed
the
feature/translations-plural
branch
from
f6fa86e to
6698aa7
Compare
dhhyi
force-pushed
the
feature/translations-plural
branch
from
6698aa7 to
ad472b7
Compare
MaxKless
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
ngx-translate does not support pluralization out of the box and a serious hack using i18nPlural pipe from Angular has to be used.
What Is the New Behavior?
Added a custom translate compiler, that handles pluralization.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Using the ngx-translate-messageformat-compiler did not work and would also pull additional dependencies.