fix: set canonical link and 'og:url' info independent from SSR container context to 'https' #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner context to 'https' closes: #749 fixes: AB#64588
dhhyi
approved these changes
Jul 8, 2021
jometzner
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production PWAs should always be run in a secure context but the PWA SSR container itself is usually not run in a secure context in production. The SSL certification is handled outside the PWAs context. This makes it hard to get the correct protocol from the PWA SSR context even though it is a secure context to the user. For this reason we always set the canonical link URLs and the 'og:url' to 'https:' to prevent false non indexable canonical links.
PR Type
[x] Bugfix
Does this PR Introduce a Breaking Change?
[x] No
Issue number: #749
AB#64674