add anchor scrolling / fragment navigation for serverHtml content #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
feature/anchor_scrolling_for_serverHtml
branch
from
3a4e6ea
to
e95278d
Compare
Sebastian-Haehnlein
suggested changes
Jan 15, 2020
… for serverHtml content (#80)
shauke
force-pushed
the
feature/anchor_scrolling_for_serverHtml
branch
from
e95278d
to
b067b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is the Current Behavior?
Anchor scrolling / fragment navigation on a pages with content fetched via ICM CMS REST API doesn't work as expected. The ishServerHtml directive does not handle such links with only the a given anchor correctly, but will reload the application to a wrong route instead of scrolling on the current page. Complete routes with fragment navigation work as expected.
Such links do not work:
<a href="#Software" title="Software">Software</a>These links would work:
<a href="page://systempage.termsAndConditions.pagelet2-Page#OtherDocuments" title="OtherDocuments">Other Documents</a>This can be tested with the "Terms & Conditions" ICM demo content.
What Is the New Behavior?
The ishServerHtml directive handles links like
<a href="#Software"as anchor links and scrolls on the current page to the according anchor.Does this PR Introduce a Breaking Change?
[x] No