Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open terms and conditions and privacy policy in new tab (ISREST-934) #84

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

suschneider
Copy link
Collaborator

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Links to the terms & conditions and the privacy policy are handle in different ways on several pages.
The terms & condition link on checkout review page leads to privacy policy.

Issue Number: ISREST-934

What Is the New Behavior?

Links to terms & conditions and privacy policy links are always opened in a new tab.
The terms & condition link on checkout review page leads to terms & condition page.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@suschneider suschneider added the bug Something isn't working label Jan 15, 2020
@suschneider suschneider added this to the 0.17 milestone Jan 15, 2020
@suschneider suschneider requested a review from shauke January 15, 2020 13:20
@suschneider suschneider self-assigned this Jan 15, 2020
@suschneider suschneider changed the title ISREST-934: open terms and conditions and privacy policy in new tab fix: open terms and conditions and privacy policy in new tab (ISREST-934) Jan 15, 2020
@shauke shauke merged commit 3664057 into develop Jan 17, 2020
@shauke shauke deleted the bugfix/terms_and_conditions_fixes branch January 17, 2020 08:33
shauke pushed a commit that referenced this pull request Jan 17, 2020
shauke pushed a commit that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants