-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cost center approval #887
Conversation
e92f6f9
to
0ce4659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for calling to talk about cost center approval. As discussed I found some issues during my review:
- Some blanks before colons, e.g. Approver : Patricia Miller.
- Cost center name is missing on some pages (only cost center no. or ID is visible).
- Approval status per approver should be displayed (maybe a success check icon when approver approved it) for pending requisitions. This allows the buyer to see which approver still needs to check the requisition.
- Info message "The requisition still needs approval..." has missing styles (maybe Purge CSS thing).
- If requisition was approved by me but is pending due to a missing second approval, the requisition should be listed in the "Approved by me" section regardless of the overall approval status. Currently requisition is no longer visible to me until second approval is done. Tabs have been renamed to "Approved Requisitions" and "Rejected Requisitions"
- If approver approves/rejects the requisition, go automatically back to "Waiting for your approval" list because there is nothing left to do for the requisition.
- Cost center approval widget is no longer visible for cost center manager after the requisition is approved or rejected.
- All approvers should be listed for an approved requisition (currently the last approver is displayed).
Please look at the points that you can fix. Leave the other points open for discussion for the REST interface.
7ce5898
to
e46efc2
Compare
projects/requisition-management/src/app/store/requisitions/requisitions.effects.ts
Show resolved
Hide resolved
...ment/src/app/pages/requisition-detail/requisition-summary/requisition-summary.component.html
Outdated
Show resolved
Hide resolved
e921b2e
to
b761166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well developed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localization reviewed
7ee8ef4
to
542d33a
Compare
… multiple permissions
…own if a cost center has already been assigned to a basket
542d33a
to
144855e
Compare
- refactor: budget localization keys
144855e
to
bff49f4
Compare
PR Type
[x] Feature
What Is the Current Behavior?
Cost center approval doesn`t work properly.
Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[x] No
Other Information
Pending issues:
AB#70000