Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cost center approval #887

Merged
merged 7 commits into from
Oct 22, 2021
Merged

feat: cost center approval #887

merged 7 commits into from
Oct 22, 2021

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Sep 23, 2021

PR Type

[x] Feature

What Is the Current Behavior?

Cost center approval doesn`t work properly.

Issue Number: Closes #

What Is the New Behavior?

  • Selected Cost Center of a requisition/order is displayed in all relevant places in PWA (same as in Responsive Starter Store)
  • Approval list shows relevant orders to approve for Cost Center Manager
  • Approval details page display cost center related information
  • Approval details popup at cart displays cost center approval related information (same as in Responsive Starter Store)
  • Cost Center approval can be triggered and is handled independently from user based approval (same as in Responsive Starter Store)

Does this PR Introduce a Breaking Change?

[x] No

Other Information

Pending issues:

  • display approval myAccount navigation item for cost center manager only if there are cost centers
  • display remaining budget in the buyer approval widget instead of already spent including this order (or fix the value after customer approval has been done)
  • remove "Please Select" of cost center in checkout if a cost center was already assigned to the basket
  • customer approval is shown as required although the order spent limit is not exceeded - it has to be fixed within the ICM https://dev.azure.com/intershop-com/Products/_workitems/edit/70546/

AB#70000

@shauke shauke added the feature New feature or request label Sep 24, 2021
@SGrueber SGrueber force-pushed the feature/cost_center_approval branch from e92f6f9 to 0ce4659 Compare September 30, 2021 14:19
@shauke shauke added this to the 1.3 milestone Oct 1, 2021
@SGrueber SGrueber marked this pull request as ready for review October 4, 2021 12:37
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for calling to talk about cost center approval. As discussed I found some issues during my review:

  • Some blanks before colons, e.g. Approver : Patricia Miller.
  • Cost center name is missing on some pages (only cost center no. or ID is visible).
  • Approval status per approver should be displayed (maybe a success check icon when approver approved it) for pending requisitions. This allows the buyer to see which approver still needs to check the requisition.
  • Info message "The requisition still needs approval..." has missing styles (maybe Purge CSS thing).
  • If requisition was approved by me but is pending due to a missing second approval, the requisition should be listed in the "Approved by me" section regardless of the overall approval status. Currently requisition is no longer visible to me until second approval is done. Tabs have been renamed to "Approved Requisitions" and "Rejected Requisitions"
  • If approver approves/rejects the requisition, go automatically back to "Waiting for your approval" list because there is nothing left to do for the requisition.
  • Cost center approval widget is no longer visible for cost center manager after the requisition is approved or rejected.
  • All approvers should be listed for an approved requisition (currently the last approver is displayed).

Please look at the points that you can fix. Leave the other points open for discussion for the REST interface.

@SGrueber SGrueber force-pushed the feature/cost_center_approval branch 2 times, most recently from 7ce5898 to e46efc2 Compare October 7, 2021 14:54
@shauke shauke self-assigned this Oct 11, 2021
@cbratsch cbratsch linked an issue Oct 13, 2021 that may be closed by this pull request
@SGrueber SGrueber force-pushed the feature/cost_center_approval branch from e921b2e to b761166 Compare October 15, 2021 10:16
M-Behr
M-Behr previously approved these changes Oct 19, 2021
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

iwiederhold
iwiederhold previously approved these changes Oct 19, 2021
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well developed!

@marschmidt89 marschmidt89 dismissed stale reviews from iwiederhold and M-Behr via dd4121c October 19, 2021 12:55
marschmidt89
marschmidt89 previously approved these changes Oct 19, 2021
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localization reviewed

shauke
shauke previously approved these changes Oct 20, 2021
@shauke shauke dismissed stale reviews from marschmidt89 and themself via 3be7eff October 20, 2021 12:16
shauke
shauke previously approved these changes Oct 20, 2021
@SGrueber SGrueber force-pushed the feature/cost_center_approval branch 2 times, most recently from 7ee8ef4 to 542d33a Compare October 21, 2021 09:37
@SGrueber SGrueber requested a review from shauke October 21, 2021 10:29
@shauke shauke force-pushed the feature/cost_center_approval branch from 542d33a to 144855e Compare October 21, 2021 13:49
@SGrueber SGrueber force-pushed the feature/cost_center_approval branch from 144855e to bff49f4 Compare October 21, 2021 15:28
@SGrueber SGrueber merged commit 2de6856 into develop Oct 22, 2021
@SGrueber SGrueber deleted the feature/cost_center_approval branch October 22, 2021 07:45
SGrueber added a commit that referenced this pull request Oct 22, 2021
SGrueber added a commit that referenced this pull request Oct 22, 2021
SGrueber added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cost centers missing on PWA version
5 participants