fix: missing styles for main navigation hover menu - removed by PurgeCSS #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
previously requested changes
Oct 6, 2021
suschneider
previously approved these changes
Oct 7, 2021
shauke
force-pushed
the
bugfix/purged_navigation_styling
branch
from
ad9a3b4 to
998edad
Compare
suschneider
previously approved these changes
Oct 7, 2021
shauke
dismissed
dhhyi’s stale review
Changed according to your suggestions. Works fine. ;)
- this way it behaves the same as within a docker build
shauke
force-pushed
the
bugfix/purged_navigation_styling
branch
from
998edad to
1ee652e
Compare
dhhyi
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
Main Navigation Hover Menu styling is missing in SSR container builds since #865. Needed hover menu styles are removed/optimized by PurgeCSS since PurgeCSS can no longer analyze
**/*spec.tsfiles for used CSS classes since they are no longer copied into the docker image (see.dockerignore).What Is the New Behavior?
Needed main navigation styles are no longer optimized/removed by PurgeCSS.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#70303